Skip to content

fix: remove answer_relevance* intrinsics; fix other intrinsics issues#690

Merged
jakelorocco merged 3 commits into
mainfrom
jal/fix-intrinsics
Mar 18, 2026
Merged

fix: remove answer_relevance* intrinsics; fix other intrinsics issues#690
jakelorocco merged 3 commits into
mainfrom
jal/fix-intrinsics

Conversation

@jakelorocco

@jakelorocco jakelorocco commented Mar 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)
  • Ran tests locally with hf cache cleared of adapters

@github-actions

github-actions Bot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@jakelorocco
jakelorocco marked this pull request as ready for review March 18, 2026 14:49
@jakelorocco
jakelorocco requested review from a team as code owners March 18, 2026 14:49
@mergify

mergify Bot commented Mar 18, 2026

Copy link
Copy Markdown

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@planetf1

planetf1 commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

reviewing & checking tests ..

@planetf1

planetf1 commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Docs/examples cleanup missed

docs/examples/intrinsics/README.md was not updated alongside the deletion of answer_relevance.py:

  • Line 16–17: ### answer_relevance.py section entry still present
  • Line 74: **answer_relevance**: Check answer-question relevance still listed under Available Intrinsics

Also no CHANGELOG/release note for the removal of the public rag.rewrite_answer_for_relevance() function.

Note: GuardianRisk.ANSWER_RELEVANCE in guardian.py is a Granite Guardian risk category — unrelated to the removed RAG intrinsic, correct to leave as-is.

@jakelorocco

jakelorocco commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

Docs/examples cleanup missed

docs/examples/intrinsics/README.md was not updated alongside the deletion of answer_relevance.py:

  • Line 16–17: ### answer_relevance.py section entry still present
  • Line 74: **answer_relevance**: Check answer-question relevance still listed under Available Intrinsics

Also no CHANGELOG/release note for the removal of the public rag.rewrite_answer_for_relevance() function.

Note: GuardianRisk.ANSWER_RELEVANCE in guardian.py is a Granite Guardian risk category — unrelated to the removed RAG intrinsic, correct to leave as-is.

Fixed the readme. Breaking an API is okay here. I'll change the PR title so it gets picked up in the auto generated changelog.

@jakelorocco jakelorocco changed the title fix: intrinsics issues blocking ci/cd pipeline fix: remove answer_relevance* intrinsics; fix other intrinsics issues Mar 18, 2026
@ink-pad

ink-pad commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Thanks for taking care of this, @jakelorocco and @planetf1

@jakelorocco
jakelorocco enabled auto-merge March 18, 2026 15:23
@jakelorocco
jakelorocco disabled auto-merge March 18, 2026 15:23
@planetf1

planetf1 commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

@jakelorocco since this is a full block I'd be inclined to merge this, and if there are followups (including docs) do in another PR

@jakelorocco
jakelorocco merged commit 1734900 into main Mar 18, 2026
8 checks passed
@jakelorocco
jakelorocco deleted the jal/fix-intrinsics branch March 18, 2026 15:29
@ajbozarth ajbozarth mentioned this pull request Mar 18, 2026
Closed
@psschwei psschwei mentioned this pull request Mar 20, 2026
Merged
8 tasks
akihikokuroda pushed a commit to akihikokuroda/mellea that referenced this pull request May 27, 2026
@jakelorocco @akihikokuroda
fix: remove answer_relevance* intrinsics; fix other intrinsics issues (…
d04ad9b 
…generative-computing#690)

* fix: add support back for older models and requirement_check adapter

* fix: fix model used in test_rag for intrinsics

* fix: remove answer_relevance_classifier and answer_relevance_rewriter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@planetf1 planetf1 planetf1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: PR #551 broke test_huggingface — catalog/repo mismatch for requirement_check

3 participants

@jakelorocco @planetf1 @ink-pad